New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8258535: jvm.ClassReader should set the accessor to the corresponding record component #4152
8258535: jvm.ClassReader should set the accessor to the corresponding record component #4152
Conversation
…om a different jar
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
@vicente-romero-oracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@vicente-romero-oracle Since your change was applied there have been 13 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f5562f1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this fix which addresses a bug in the records implementation. The issue is that when a record is read by jvm.ClassReader, the record components are not linked to its corresponding accessor. If users try to look for the accessor using javax.lang.model API, using an annotation processor for example, then they will find that the accessor is null.
TIA for the review
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4152/head:pull/4152
$ git checkout pull/4152
Update a local copy of the PR:
$ git checkout pull/4152
$ git pull https://git.openjdk.java.net/jdk pull/4152/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4152
View PR using the GUI difftool:
$ git pr show -t 4152
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4152.diff